Discussion:
[2.6 patch] jffs/jffs2: remove wrong function prototypes
Adrian Bunk
2005-07-31 17:00:29 UTC
Permalink
This patch removes prototypes for the generic_file_open and
generic_file_llseek functions.

Besides being superfluous because they are already present in fs.h, they
were also wrong because the actual functions aren't weak functions.


Signed-off-by: Adrian Bunk <***@stusta.de>

---

fs/jffs/inode-v23.c | 3 ---
fs/jffs2/file.c | 3 ---
2 files changed, 6 deletions(-)

--- linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c.old 2005-07-31 18:43:46.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c 2005-07-31 18:44:15.000000000 +0200
@@ -1629,9 +1629,6 @@
}


-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *, loff_t, int) __attribute__((weak));
-
static struct file_operations jffs_file_operations =
{
.open = generic_file_open,
--- linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c.old 2005-07-31 18:44:31.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c 2005-07-31 18:44:40.000000000 +0200
@@ -21,9 +21,6 @@
#include <linux/jffs2.h>
#include "nodelist.h"

-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *file, loff_t offset, int origin) __attribute__((weak));
-
static int jffs2_commit_write (struct file *filp, struct page *pg,
unsigned start, unsigned end);
static int jffs2_prepare_write (struct file *filp, struct page *pg,
Loading...